sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106

mkoeppe · 2023-02-13T02:08:17Z

📚 Description

Fixes #34955

📝 Checklist

I have made sure that the title is self-explanatory and the description concisely explains the PR.
I have linked an issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

Depends on #35119

…xport of is_FiniteField

…eField_base

…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21

tobiasdiez · 2023-02-13T12:09:34Z

There are build errors here

…_rings_abc_finitefield__deprecate_is_finitefield

src/sage/crypto/stream.py

src/sage/databases/findstat.py

codecov-commenter · 2023-02-14T23:15:37Z

Codecov Report

Patch coverage: 99.15% and project coverage change: -0.01 ⚠️

Comparison is base (f449b14) 88.62% compared to head (a9d9420) 88.61%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35106      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.01%     
===========================================
  Files         2148     2148              
  Lines       398653   398679      +26     
===========================================
- Hits        353308   353292      -16     
- Misses       45345    45387      +42

Impacted Files	Coverage Δ
src/sage/databases/findstat.py	`27.45% <0.00%> (-0.03%)`	⬇️
...c/sage/rings/finite_rings/finite_field_ntl_gf2e.py	`96.29% <ø> (ø)`
src/sage/crypto/classical.py	`89.10% <100.00%> (ø)`
src/sage/crypto/lattice.py	`93.84% <100.00%> (ø)`
src/sage/crypto/lfsr.py	`95.16% <100.00%> (+0.07%)`	⬆️
src/sage/crypto/lwe.py	`91.98% <100.00%> (+0.07%)`	⬆️
src/sage/crypto/mq/rijndael_gf.py	`80.09% <100.00%> (-0.05%)`	⬇️
src/sage/crypto/public_key/blum_goldwasser.py	`88.69% <100.00%> (-0.20%)`	⬇️
src/sage/crypto/stream.py	`74.73% <100.00%> (ø)`
src/sage/crypto/util.py	`96.61% <100.00%> (+0.05%)`	⬆️
... and 59 more

... and 34 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…eprecate_is_finitefield

mkoeppe · 2023-02-20T04:57:58Z

There's no work item to be done.

tobiasdiez · 2023-02-20T05:28:01Z

#35106 (comment)

mkoeppe · 2023-02-20T05:29:49Z

Yes, I have already explained to you what these changes are doing and why they are in scope.

…eprecate_is_finitefield SageMath version 10.0.beta3, Release Date: 2023-03-02

…eprecate_is_finitefield SageMath version 10.0.beta4, Release Date: 2023-03-12

…,quadratic_forms}

…Q/;s/ Z as ZZ/ ZZ/;'

…lint

…ate imports from the same module

…unctions,quadratic_forms} | xargs sed -i.bak 's/GCD as gcd/gcd/'

…lfunctions,quadratic_forms} | xargs sed -i.bak 's/XGCD as xgcd/xgcd/'

… in merge

…nitefield' into t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages

github-actions · 2023-03-13T04:18:48Z

Documentation preview for this PR is ready! 🎉
Built with commit: a9d9420

dimpase

lgtm

…ages  ### 📚 Description Fixes #34201    ### 📝 Checklist    - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   - Depends on #35090 - Depends on #35098 - Depends on #35099 - Depends on #35105 - Depends on #35106 - Depends on #35107 URL: #35110 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik

Matthias Koeppe added 10 commits December 18, 2022 13:40

sage.rings.finite_rings: Deprecate is_FiniteField, is_PrimeFiniteField

53ede8c

sage.rings.finite_rings: Make it a namespace package

8d4d8e5

src/sage/rings/finite_rings/finite_field_constructor.py: Restore re-e…

6ce26bc

…xport of is_FiniteField

src/sage/rings/finite_rings/hom_finite_field.pyx: Import ABC as Finit…

98a5484

…eField_base

sage.rings.finite_rings: Deprecate is_FiniteFieldElent

2e6b5ef

Fixups

3be7c97

Fixups

97a363e

Fixup: Elements of finite fields are not instances of FieldElement

0c01403

src/sage/crypto/mq/rijndael_gf.py: Fix imports

9f4d1c4

Merge tag '9.8.beta6' into t/32664/add_sage_rings_abc_finitefield__de…

9ebadcf

…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21

mkoeppe added s: needs review t: refactoring labels Feb 13, 2023

mkoeppe added this to the sage-10.0 milestone Feb 13, 2023

tobiasdiez added s: needs work and removed s: needs review labels Feb 13, 2023

mkoeppe added s: needs review and removed s: needs work labels Feb 13, 2023

Merge remote-tracking branch 'upstream/develop' into t/32664/add_sage…

30bc1c6

…_rings_abc_finitefield__deprecate_is_finitefield

tobiasdiez suggested changes Feb 14, 2023

View reviewed changes

src/sage/crypto/stream.py Outdated Show resolved Hide resolved

src/sage/databases/findstat.py Show resolved Hide resolved

tobiasdiez added s: needs work and removed s: needs review labels Feb 14, 2023

mkoeppe requested a review from tobiasdiez February 14, 2023 05:29

mkoeppe added s: needs review and removed s: needs work labels Feb 14, 2023

mkoeppe self-assigned this Feb 18, 2023

Merge branch 'develop' into t/32664/add_sage_rings_abc_finitefield__d…

7265733

…eprecate_is_finitefield

tobiasdiez added s: needs work and removed s: needs review labels Feb 20, 2023

mkoeppe added the s: needs review label Feb 20, 2023

mkoeppe requested a review from tscrim February 20, 2023 05:16

Matthias Koeppe and others added 13 commits February 20, 2023 18:37

src/sage/rings/finite_rings: Update doctest output (trac->github)

40a7d57

Merge tag '10.0.beta3' into t/32664/add_sage_rings_abc_finitefield__d…

12b4440

…eprecate_is_finitefield SageMath version 10.0.beta3, Release Date: 2023-03-02

Merge tag '10.0.beta4' into t/32664/add_sage_rings_abc_finitefield__d…

2459849

…eprecate_is_finitefield SageMath version 10.0.beta4, Release Date: 2023-03-12

sage -fiximports src/sage/{arith,crypto,databases,dynamics,lfunctions…

d591aec

…,quadratic_forms}

git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ Q…

9435a7e

…Q/;s/ Z as ZZ/ ZZ/;'

src/sage/databases/findstat.py: Hide a legitimate .all import from re…

3d51e7b

…lint

sage.{crypto,databases,dynamics,lfunctions,quadratic_forms}: Consolid…

350979e

…ate imports from the same module

src/sage/quadratic_forms/ternary_qf.py: Fix import syntax

f210dce

src/sage/crypto/public_key/blum_goldwasser.py: Fix up relative imports

feb6525

Replace relative imports by absolute imports because pytest

6e96393

Fix up syntax

4571804

git grep -l 'GCD as gcd' src/sage/{arith,crypto,databases,dynamics,lf…

9721de1

…unctions,quadratic_forms} | xargs sed -i.bak 's/GCD as gcd/gcd/'

git grep -l 'XGCD as xgcd' src/sage/{arith,crypto,databases,dynamics,…

f9f6542

…lfunctions,quadratic_forms} | xargs sed -i.bak 's/XGCD as xgcd/xgcd/'

mkoeppe force-pushed the t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages branch from b1f9f69 to f9f6542 Compare March 13, 2023 01:13

Matthias Koeppe added 2 commits March 12, 2023 19:23

src/sage/rings/padics/padic_template_element.pxi: Restore import lost…

e62066f

… in merge

Merge branch 't/32664/add_sage_rings_abc_finitefield__deprecate_is_fi…

a9d9420

…nitefield' into t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages

mkoeppe requested a review from dimpase March 13, 2023 08:36

dimpase approved these changes Mar 13, 2023

View reviewed changes

dimpase added s: positive review and removed s: needs review labels Mar 13, 2023

tobiasdiez mentioned this pull request Mar 16, 2023

sage.{functions,interfaces,symbolic}: Replace imports from sage.*.all for namespace packages #35105

Merged

4 tasks

vbraun merged commit b82f457 into sagemath:develop Mar 19, 2023

mkoeppe removed the s: positive review label Mar 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106

sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106

mkoeppe commented Feb 13, 2023 •

edited

Loading

tobiasdiez commented Feb 13, 2023

codecov-commenter commented Feb 14, 2023 •

edited

Loading

mkoeppe commented Feb 20, 2023

tobiasdiez commented Feb 20, 2023

mkoeppe commented Feb 20, 2023

github-actions bot commented Mar 13, 2023

dimpase left a comment

sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106

sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106

Conversation

mkoeppe commented Feb 13, 2023 • edited Loading

📚 Description

📝 Checklist

⌛ Dependencies

tobiasdiez commented Feb 13, 2023

codecov-commenter commented Feb 14, 2023 • edited Loading

Codecov Report

mkoeppe commented Feb 20, 2023

tobiasdiez commented Feb 20, 2023

mkoeppe commented Feb 20, 2023

github-actions bot commented Mar 13, 2023

dimpase left a comment

Choose a reason for hiding this comment

mkoeppe commented Feb 13, 2023 •

edited

Loading

codecov-commenter commented Feb 14, 2023 •

edited

Loading